From: Florian Müllner <fmuellner@gnome.org>
Date: Tue, 31 Mar 2026 16:21:58 +0000 (+0200)
Subject: portalHelper: Add basic zoom support
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~10^2^2~67
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d8ae7ce489a6f10c31a1954dad4306af94af8aca;p=gnome-shell.git

portalHelper: Add basic zoom support

A portal login page may have poor readability that require page zoom
functionality as implemented by most browsers.

However WebView does not provide this functionality itself, it only
exposes API that allows implementing it.

Add basic zoom in/out/reset actions based on epiphany's implementation,
and hook them up to accels.

Exposing them more prominently (as buttons or in a menu) would require
some UI rework, so leave that for a later.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/9129
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4159>
---

diff --git a/js/portalHelper/main.js b/js/portalHelper/main.js
index 46bd074d4..a7bb62dbd 100644
--- a/js/portalHelper/main.js
+++ b/js/portalHelper/main.js
@@ -25,6 +25,12 @@ const PortalHelperSecurityLevel = {
     INSECURE: 2,
 };
 
+const ZoomAction = {
+    NORMAL: 0,
+    IN: 1,
+    OUT: 2,
+};
+
 const HTTP_URI_FLAGS =
     GLib.UriFlags.HAS_PASSWORD |
     GLib.UriFlags.ENCODED_PATH |
@@ -117,6 +123,18 @@ class PortalWindow extends Gtk.ApplicationWindow {
             default_height: 450,
         });
 
+        this.add_action_entries(
+            [{
+                name: 'zoom-in',
+                activate: () => this._setZoom(ZoomAction.IN),
+            }, {
+                name: 'zoom-out',
+                activate: () => this._setZoom(ZoomAction.OUT),
+            }, {
+                name: 'zoom-normal',
+                activate: () => this._setZoom(ZoomAction.NORMAL),
+            }]);
+
         const headerbar = new Gtk.HeaderBar();
         this._secureMenu = new PortalSecurityButton();
         headerbar.pack_start(this._secureMenu);
@@ -283,6 +301,58 @@ class PortalWindow extends Gtk.ApplicationWindow {
         decision.use();
         return true;
     }
+
+    _getChangedZoomLevel(zoomAction) {
+        if (zoomAction === ZoomAction.NORMAL)
+            return 1.0;
+
+        // Adapted from ephy-zoom.c
+        const zoomSteps = [
+            0.30,
+            0.50,
+            0.67,
+            0.80,
+            0.90,
+            1.00,
+            1.10,
+            1.20,
+            1.33,
+            1.50,
+            1.70,
+            2.00,
+            2.40,
+            3.00,
+        ];
+
+        const {zoomLevel} = this._webView;
+
+        let i = zoomSteps.indexOf(zoomLevel);
+
+        if (i < 0) {
+            // No exact match found, try to find the nearest value
+            i = zoomSteps.findLastIndex(v => v < zoomLevel);
+        }
+
+        if (i < 0) {
+            // Still no match? Return default
+            return 1.0;
+        }
+
+        let newLevel;
+        if (zoomAction === ZoomAction.OUT && i > 0)
+            newLevel = zoomSteps[i - 1];
+        else if (zoomAction === ZoomAction.IN && i < zoomSteps.length - 1)
+            newLevel = zoomSteps[i + 1];
+        else
+            newLevel = zoomLevel; // ensure that we have a consistent value
+
+        return newLevel;
+    }
+
+    _setZoom(zoomAction) {
+        const zoomLevel = this._getChangedZoomLevel(zoomAction);
+        this._webView.set_zoom_level(zoomLevel);
+    }
 });
 
 const WebPortalHelper = GObject.registerClass(
@@ -301,6 +371,12 @@ class WebPortalHelper extends Adw.Application {
         action.connect('activate', () => this.active_window.destroy());
         this.add_action(action);
 
+        this.set_accels_for_action('win.zoom-in',
+            ['<Primary>plus', '<Primary>KP_Add', '<Primary>equal', 'ZoomIn']);
+        this.set_accels_for_action('win.zoom-out',
+            ['<Primary>minus', '<Primary>KP_Subtract', 'ZoomOut']);
+        this.set_accels_for_action('win.zoom-normal',
+            ['<Primary>0', '<Primary>KP_0']);
         this.set_accels_for_action('app.quit', ['<Primary>q', '<Primary>w']);
     }